Skip to content

Conversation

@sarawilcox
Copy link
Contributor

@sarawilcox sarawilcox commented Sep 11, 2025

Description

We've identified a number of places where our components are inconsistent, look too much like GOV, aren't up to date with latest tested practice, or have clinical content that has been superceded.

I've updated the content in a number of components.

LATEST: INCOMPLETE

Related issue

#2163

Checklist

@colinrotherham colinrotherham temporarily deployed to nhsuk-service-manual-pr-2287 September 11, 2025 11:58 Inactive
@sarawilcox
Copy link
Contributor Author

sarawilcox commented Sep 11, 2025

@colinrotherham it looks like I've done something wrong on the hint text page with the checkbox example at the top of the page. It's no longer displaying. Would you mind taking a look when you have a mo, please?

In fact, it looks like I've knocked out a couple of examples on that page when I changed the content in the question.

It used to say:

How would you like to be contacted?

And we've been advised to make it:

How do you want to be contacted about this?

@sarawilcox sarawilcox changed the title Updates to design system examples august25 Updates to design system examples august25 WIP Sep 11, 2025
@colinrotherham colinrotherham force-pushed the updates-to-design-system-examples-august25 branch from 99bd518 to fbf4134 Compare September 11, 2025 13:45
@colinrotherham colinrotherham temporarily deployed to nhsuk-service-manual-pr-2287 September 11, 2025 13:45 Inactive
@colinrotherham
Copy link
Contributor

All fixed again @sarawilcox

There was a little typo and I've fixed the 404 pages for component examples

@colinrotherham
Copy link
Contributor

@sarawilcox I noticed the reverse breadcrumb content had changed 👀

We've released reverse back links and action links since too so I've updated their content to match

That alright?

@sarawilcox
Copy link
Contributor Author

Thanks @colinrotherham . I'll come back to this next week.

{{ input({
label: {
html: '<span class="nhsuk-u-visually-hidden">Building and street line 2 of 2</span>'
text: "Address line 2 (optional)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My personal view is that this visible label isn't necessary - hence prefer the hidden version. I note the new version matches GOV.UK though so presumably they decided to stop hiding it too.

@colinrotherham colinrotherham temporarily deployed to nhsuk-service-manual-pr-2287 September 15, 2025 13:51 Inactive
@colinrotherham colinrotherham temporarily deployed to nhsuk-service-manual-pr-2287 September 15, 2025 13:55 Inactive
@sarawilcox
Copy link
Contributor Author

@sarawilcox I noticed the reverse breadcrumb content had changed 👀

We've released reverse back links and action links since too so I've updated their content to match

That alright?

Hi @colinrotherham , I've made some minor content tweaks to shorten and align the content across the various reverse examples.

@colinrotherham colinrotherham force-pushed the updates-to-design-system-examples-august25 branch from a768d1b to eb34f60 Compare September 15, 2025 15:23
@colinrotherham colinrotherham temporarily deployed to nhsuk-service-manual-pr-2287 September 15, 2025 15:23 Inactive
@colinrotherham
Copy link
Contributor

Thanks @sarawilcox I've fixed the conflict too

We had a few Nunjucks examples/patterns that weren't following our usual rules so I've pushed up some fixes

E.g. Preferring double quotes, moving {% extends %} to the top etc

@colinrotherham colinrotherham temporarily deployed to nhsuk-service-manual-pr-2287 September 15, 2025 15:28 Inactive
@colinrotherham colinrotherham force-pushed the updates-to-design-system-examples-august25 branch from 9ad6aaa to 6aa32cc Compare September 15, 2025 15:38
@colinrotherham colinrotherham temporarily deployed to nhsuk-service-manual-pr-2287 September 15, 2025 15:39 Inactive
@colinrotherham colinrotherham force-pushed the updates-to-design-system-examples-august25 branch from 6aa32cc to 95fa4cd Compare September 17, 2025 07:45
@colinrotherham colinrotherham temporarily deployed to nhsuk-service-manual-pr-2287 September 17, 2025 07:45 Inactive
@colinrotherham colinrotherham force-pushed the updates-to-design-system-examples-august25 branch from 95fa4cd to d0b12df Compare September 24, 2025 16:29
@colinrotherham colinrotherham temporarily deployed to nhsuk-service-manual-pr-2287 September 24, 2025 16:30 Inactive
@anandamaryon1 anandamaryon1 temporarily deployed to nhsuk-service-manual-pr-2287 October 13, 2025 11:37 Inactive
@anandamaryon1 anandamaryon1 temporarily deployed to nhsuk-service-manual-pr-2287 October 13, 2025 13:03 Inactive
@anandamaryon1 anandamaryon1 temporarily deployed to nhsuk-service-manual-pr-2287 October 13, 2025 13:27 Inactive
@anandamaryon1 anandamaryon1 temporarily deployed to nhsuk-service-manual-pr-2287 October 13, 2025 14:38 Inactive
@colinrotherham colinrotherham force-pushed the updates-to-design-system-examples-august25 branch from a478083 to ea6087f Compare November 17, 2025 11:44
@colinrotherham colinrotherham temporarily deployed to nhsuk-service-manual-pr-2287 November 17, 2025 11:44 Inactive
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@anandamaryon1 anandamaryon1 modified the milestones: 8.5.0, 8.4.0 Nov 17, 2025
@colinrotherham colinrotherham merged commit c6dd3ba into main Nov 18, 2025
6 of 7 checks passed
@colinrotherham colinrotherham deleted the updates-to-design-system-examples-august25 branch November 18, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants